Skip to content

fix: import Optional when properties are nullable or not required#181

Merged
dbanty merged 1 commit into
mainfrom
nullable-fix-0.5
Sep 4, 2020
Merged

fix: import Optional when properties are nullable or not required#181
dbanty merged 1 commit into
mainfrom
nullable-fix-0.5

Conversation

@dbanty
Copy link
Copy Markdown
Collaborator

@dbanty dbanty commented Sep 4, 2020

A slightly modified cherry pick from #180 to fix the issue in 0.5

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 4, 2020

Codecov Report

Merging #181 into main will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              main     #181      +/-   ##
===========================================
- Coverage   100.00%   99.92%   -0.08%     
===========================================
  Files           41       41              
  Lines         1276     1251      -25     
===========================================
- Hits          1276     1250      -26     
- Misses           0        1       +1     
Impacted Files Coverage Δ
openapi_python_client/parser/properties.py 100.00% <100.00%> (ø)
openapi_python_client/__init__.py 99.35% <0.00%> (-0.65%) ⬇️
openapi_python_client/parser/errors.py 100.00% <0.00%> (ø)
openapi_python_client/parser/openapi.py 100.00% <0.00%> (ø)
openapi_python_client/parser/reference.py 100.00% <0.00%> (ø)
openapi_python_client/parser/responses.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30edc56...1172295. Read the comment docs.

@dbanty dbanty merged commit c006ea0 into main Sep 4, 2020
@dbanty dbanty deleted the nullable-fix-0.5 branch September 4, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants